bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

ent/encryption: Replace manual string suffix checks with ends_with()

Browse Source 
Replace manual string suffix comparison (length check + std::equal) with
std::string::ends_with() introduced in C++20 for better readability.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#22764
This commit is contained in:
Kefu Chai
2025-02-10 09:44:27 +08:00
committed by Pavel Emelyanov
parent d4c531307d
commit 09a090e410
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ent/encryption/symmetric_key.cc
View File

@@ -94,8 +94,8 @@ encryption::parse_key_spec(const sstring& alg) {
std::transform(mode.begin(), mode.end(), mode.begin(), ::tolower); std::transform(mode.begin(), mode.end(), mode.begin(), ::tolower);
std::transform(padd.begin(), padd.end(), padd.begin(), ::tolower); std::transform(padd.begin(), padd.end(), padd.begin(), ::tolower);
static const std::string padding = "padding"; static constexpr std::string_view padding = "padding";
if (padd.size() > padding.size() && std::equal(padding.rbegin(), padding.rend(), padd.rbegin())) { if (padd.ends_with(padding)) {
padd.resize(padd.size() - padding.size()); padd.resize(padd.size() - padding.size());
} }