[compiler] Fix false positive for useMemo reassigning context vars

Within a function expresssion local variables use StoreContext, not StoreLocal, so the reassignment check here was firing too often. We should only report an error for variables that are declared outside the function, ie part of its `context`.

compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateUseMemo.ts

@@ -184,25 +184,28 @@ function validateNoContextVariableAssignment(
   fn: HIRFunction,
   errors: CompilerError,
 ): void {
+  const context = new Set(fn.context.map(place => place.identifier.id));
   for (const block of fn.body.blocks.values()) {
     for (const instr of block.instructions) {
       const value = instr.value;
       switch (value.kind) {
         case 'StoreContext': {
-          errors.pushDiagnostic(
+          if (context.has(value.lvalue.place.identifier.id)) {
-            CompilerDiagnostic.create({
+            errors.pushDiagnostic(
-              category: ErrorCategory.UseMemo,
+              CompilerDiagnostic.create({
-              reason:
+                category: ErrorCategory.UseMemo,
-                'useMemo() callbacks may not reassign variables declared outside of the callback',
+                reason:
-              description:
+                  'useMemo() callbacks may not reassign variables declared outside of the callback',
-                'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
+                description:
-              suggestions: null,
+                  'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
-            }).withDetails({
+                suggestions: null,
-              kind: 'error',
+              }).withDetails({
-              loc: value.lvalue.place.loc,
+                kind: 'error',
-              message: 'Cannot reassign variable',
+                loc: value.lvalue.place.loc,
-            }),
+                message: 'Cannot reassign variable',
-          );
+              }),
+            );
+          }
           break;
         }
       }

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/reassign-variable-in-usememo.expect.md

@@ -0,0 +1,45 @@
+
+## Input
+
+```javascript
+// @flow
+export hook useItemLanguage(items) {
+  return useMemo(() => {
+    let language: ?string = null;
+    items.forEach(item => {
+      if (item.language != null) {
+        language = item.language;
+      }
+    });
+    return language;
+  }, [items]);
+}
+
+```
+
+## Code
+
+```javascript
+import { c as _c } from "react/compiler-runtime";
+export function useItemLanguage(items) {
+  const $ = _c(2);
+  let language;
+  if ($[0] !== items) {
+    language = null;
+    items.forEach((item) => {
+      if (item.language != null) {
+        language = item.language;
+      }
+    });
+    $[0] = items;
+    $[1] = language;
+  } else {
+    language = $[1];
+  }
+  return language;
+}
+
+```
+      
+### Eval output
+(kind: exception) Fixture not implemented

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/reassign-variable-in-usememo.js

@@ -0,0 +1,12 @@
+// @flow
+export hook useItemLanguage(items) {
+  return useMemo(() => {
+    let language: ?string = null;
+    items.forEach(item => {
+      if (item.language != null) {
+        language = item.language;
+      }
+    });
+    return language;
+  }, [items]);
+}