bahman/react
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
2,439 Commits 846 Branches 165 Tags
e6134c307e2bb7765aaa747eb5d2136fc18abbd7
Commit Graph

1023 Commits

Author SHA1 Message Date
Paul O’Shannessy
0cf686fe1e Merge pull request #1738 from cassus/master 
Add missing markerStart, markerMid, markerEnd SVG attributes
 2014-06-26 15:24:30 -07:00
Paul O’Shannessy
3581a92fc3 Merge pull request #1642 from ryanseddon/trimCSSValues 
Correctly trim strings for css properties
 2014-06-25 22:02:54 -07:00
Paul O’Shannessy
295da0a795 Merge pull request #1741 from spicyj/mount-unused 
Remove unused properties from ReactMount
 2014-06-25 21:24:42 -07:00
Ben Alpert
b8ad5a23c6 Remove unused properties from ReactMount 
(useTouchEvents lives in EventPluginUtils.)

Test Plan: jest
 2014-06-24 22:03:43 -07:00
Cheng Lou
d52bebd07b Merge pull request #1716 from somethingkindawierd/master 
Removes value attribute from rendered html of textarea
 2014-06-24 19:14:19 -07:00
Cheng Lou
a0486514a3 Merge pull request #1737 from spicyj/notime 
Remove timing metrics from Transaction
 2014-06-24 11:02:22 -07:00
Paul O’Shannessy
b018870091 Merge pull request #1664 from spicyj/warn-pooling 
Add helpful message about pooled classes
 2014-06-24 11:01:21 -07:00
Jon Beebe
e077dd40eb Adds empty onChange handler to textarea test 2014-06-24 07:26:07 -05:00
Cassus Adam Banko
30705f794c Add missing markerStart, markerMid, markerEnd SVG attributes 2014-06-24 11:17:34 +02:00
Ben Alpert
1c44b874fc Remove timing metrics from Transaction 
No one uses these and they weren't meant to be left in.

Test Plan: jest
 2014-06-23 20:32:12 -07:00
Ben Alpert
e65f17b86c Add helpful message about pooled classes 
Hopefully this will make fewer people confused at all of the null properties. The string won't wrap nicely so I tried to keep it pithy:

https://s3.amazonaws.com/uploads.hipchat.com/6574/26709/v8vzKAC784QMkX2/upload.png
 2014-06-23 14:30:40 -07:00
Cheng Lou
f81e213f41 Merge pull request #1495 from syranide/ie8noscript 
Fix ReactEmptyComponent disappearing and throwing in IE8
 2014-06-23 13:38:36 -07:00
Ryan Seddon
2bff5c5c7e Correctly trim strings for css properties 
* If a unitless value is passed with a space it'll return `1 px`
 2014-06-23 09:43:50 +10:00
petehunt
c33cceb466 Expose React.addons.Perf 2014-06-20 17:55:48 -04:00
Paul O’Shannessy
f0fc42af77 Merge pull request #1464 from spicyj/style-esc 
Don't double-escape style names
 2014-06-20 12:12:18 -07:00
Jonas Enlund
0377ec579e Added missing SVG attributes: fill-opacity, font-family, font-size, opacity, stroke-opacity. 
Closes #1557
 2014-06-20 12:45:31 -04:00
Josh Bassett
11486f1b31 Add 'patternContentUnits' to SVG attributes. 
Closes #1702
 2014-06-20 12:45:23 -04:00
Nate Hunzaker
3f29d5d6cb Add support for patternUnits attribute. 
The patternUnits attribute defines how a pattern's coordinate system is
defined (x, y, width, height). This is particularly important when using
repeatable patterns in SVG. This commit adds this attribute to the lists
of known properties.

Closes #1548
 2014-06-20 11:32:31 -04:00
Brandon Bloom
aebb3261ee Add support for SVG ellipse elements. 
Closes #1675
 2014-06-20 11:29:19 -04:00
Andreas Svensson
b36e05b0af Fix ReactEmptyComponent disappearing and throwing in IE8 2014-06-20 10:08:49 +02:00
Ben Newman
4cef56d73b Fix tests broken by undefined window references in ReactEventListener. 
This test breakage blames to e1c2d02fdd.
 2014-06-19 15:32:45 -04:00
Jon Beebe
b9c132e58a Removes value from rendered attributes of textarea 2014-06-19 07:14:49 -05:00
Paul O’Shannessy
92e3384cd2 Merge pull request #1513 from danielschonfeld/shouldcomponentupdate-boolean 
Warn if shouldComponentUpdate returns anything other than true/false
 2014-06-18 11:29:31 -07:00
Paul O’Shannessy
8bbbe900a5 Sync out camelize module 
For use in #1662
 2014-06-17 09:27:59 -07:00
Ben Alpert
52127dd7cf Remove unnecessary topLevelTypes indirection 
topLevelTypes is a key mirror, so dependency and topLevelType are always the same here.
 2014-06-16 12:18:19 -07:00
Pete Hunt
c93583c84f Remove bad perf metric 
Remove a bad perf metric. Will investigate later.
 2014-06-14 20:40:09 -07:00
Pete Hunt
e1c2d02fdd Create ReactEventListener 
Per our discussion friday, this creates ReactEventListener and renames variables to use the "handle"
nomenclature.
 2014-06-14 20:38:45 -07:00
Marshall Roch
a6cd945d9f Fix 'this' in static methods 
binds static methods on the descriptor to the component's actual constructor, so that `foo.constructor.bar()` and `Foo.bar()` run with the same `this`.
 2014-06-14 20:37:51 -07:00
Tim Yung
431155d2e2 Revert #1536 
It's causing issues in product code. Reverting until it can be
investigated further.
 2014-06-14 20:36:07 -07:00
Kunal Mehta
0f7423f31d Merge pull request #1661 from spicyj/test-ie10-select-multiple 
Fix select switching to multiple in IE
 2014-06-13 14:24:50 -07:00
Cheng Lou
3eb36415bd Merge pull request #1206 from brandonbloom/apply 
$apply directive for update
 2014-06-12 20:34:29 -07:00
Cheng Lou
4329d5ac38 Merge pull request #1611 from mathieumg/master 
Added 'objectOf' PropType validator to iterate on objects and validate properties.
 2014-06-12 20:19:33 -07:00
Brandon Bloom
86161c9c48 $apply command for update 2014-06-12 23:10:14 -04:00
Mathieu M-Gosselin
4852c30d62 Added 'objectOf' PropType validator to iterate on object literals and 
validate properties.
 2014-06-11 21:12:05 -04:00
Cheng Lou
303a719f92 Merge pull request #1658 from spicyj/test-ie10-submit-label 
Fix submit-button value test in IE10
 2014-06-11 13:44:27 -07:00
Cheng Lou
9eff32c80c Merge pull request #1659 from spicyj/test-ie10-iframe 
Fix EnterLeaveEventPlugin-test in IE10
 2014-06-11 13:44:16 -07:00
Cheng Lou
92c174fec8 Merge pull request #1671 from gasi/fix-unset-style 
Prevent null reference access when unsetting styles
 2014-06-11 11:27:37 -07:00
Cheng Lou
36f2999d47 Merge pull request #1660 from spicyj/test-ie10-proptypesname 
Fix PropTypes test in IE10
 2014-06-11 10:34:28 -07:00
Ben Alpert
8e2dcceee3 Merge pull request #1597 from spicyj/defaultprops-autobind 
Auto-bind before getDefaultProps
 2014-06-11 10:14:31 -07:00
Daniel Gasienica
7c2dec5bd3 Prevent null reference access when unsetting styles 2014-06-10 13:33:32 -07:00
Ben Alpert
eaa68b8e6b Fix select switching to multiple in IE 
This one was an actual behavioral bug rather than a bug with the tests; our intention was that the first element from the `defaultValue` array would remain selected but IE seemed to be choosing the last one instead. Now we set the value for uncontrolled components in componentDidUpdate when switching from multiple to non-multiple to ensure that a consistent option gets selected.

Test Plan: Ran the ReactDOMSelect tests in jest, phantomjs, IE10, Chrome, and Firefox. Also tested an uncontrolled select manually to make sure that nothing crazy happened when switching between options.
 2014-06-07 19:16:34 -07:00
Ben Alpert
7cd5e9b399 Fix PropTypes test in IE10 
Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
 2014-06-07 18:56:28 -07:00
Ben Alpert
5790a75622 Fix submit-button value test in IE10 
Test Plan: Ran test in jest, phantomjs, IE10, Chrome, and Firefox.
 2014-06-07 18:50:29 -07:00
Ben Alpert
e938116549 Fix EnterLeaveEventPlugin-test in IE10 
Previously this was failing because iframeDocument.body wasn't properly initialized. Creating the document this way seems to work in all environments

Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
 2014-06-07 18:45:32 -07:00
cpojer
eebcf9f888 Fix ExecutionEnvironment.canUseDOM for IE8. 2014-06-05 12:44:24 -07:00
Ben Alpert
e501238c10 Fix getEventModifierState, no allocations 
Alternative to #1637 that doesn't allocate on every event.

Test Plan: Crossed fingers.
 2014-06-03 14:35:29 -07:00
Ben Alpert
3e34739cb9 Fix onLoad and onError on images 
Fixes bug introduced in c62c2c5.

Test Plan: Tested that the onLoad event was properly triggered on an image. Didn't test onError but I can only assume that it works equally well.
 2014-05-30 16:53:46 -07:00
Fred Zhao
50516585a4 Update findComponentRoot and processUpdates warnings for SVG 
I ran into a really difficult-to-debug issue with a React app with SVG
elements. Christopher sat down with me for a while and we finally figured out
that the browser was moving non-SVG elements out of a parent `<svg>` node which
triggered the `processUpdates()` invariant. This updates the error message
thrown from there to include this scenario in the possible issues list.
 2014-05-28 18:19:49 -07:00
Paul O’Shannessy
6c7abd36dd Sync upstream modules 
crateObjectFrom is no longer used (was used in ReactPropTypes). Others are small changes.
 2014-05-28 15:13:02 -07:00
Paul O’Shannessy
0ad8cfad1a Merge pull request #1590 from spicyj/svg-classname 
Handle className properly on SVG nodes
 2014-05-28 10:14:59 -07:00